A number of fixes to compile with VS2012 and Xcode5 #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/drivers/BoostDriver.cpp
Member
Author
|
I don't feel hvellyr/cucumber-cpp@0e76db6 is the right fix for the compiler warning. I'll try to refactor my messy hooks code to fix it. |
Alternative to hvellyr/cucumber-cpp@0e76db6 Hooks need a wider refactoring that is out of scope for this
Member
Author
|
84ab6fa should fix the method hiding warning (that I can't turn on with gcc!). Unfortunately the hooks implementation is so bad that there is no simple and clean fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #72 from @hvellyr that now has too many conflicts